Skip to content

feat: add Chinese Traditional 1k, 5k, 10k, and 50k word lists (@nota-noob) #7479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nota-noob wants to merge 18 commits into
base: master
Choose a base branch
from
Open

feat: add Chinese Traditional 1k, 5k, 10k, and 50k word lists (@nota-noob) #7479

nota-noob wants to merge 18 commits into from
+66,056 −8

Conversation

@nota-noob
Copy link

@nota-noob nota-noob commented Feb 6, 2026 •
edited
Loading

Description

This pr adds support for additional word lists for the Traditional Chinese language.

  • created chinese_traditional_1k.json, chinese_traditional_5k.json, chinese_traditional_10k.json, chinese_traditional_50k.json
  • added each to LanguageSchema and LanguageGroups

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/schemas/src/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/schemas/src/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • (optional) Add theme css file to frontend/static/themes
    • Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/schemas/src/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Adding a font?
    • Make sure to follow the fonts documentation
    • Add font file to frontend/static/webfonts
    • Add font to packages/schemas/src/fonts.ts
    • Add font to frontend/src/ts/constants/fonts.ts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

Copilot AI review requested due to automatic review settings February 6, 2026 22:38
@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. packages Changes in local packages labels Feb 6, 2026
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Feb 6, 2026
@fehmer fehmer added the format Ask the bot to fix formatting on this pr label Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Feb 6, 2026
Copilot AI reviewed Feb 6, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds additional Traditional Chinese (zh-Hant) word list variants to the shared language schema and the frontend language group list, plus new static language JSON assets to back those options.

Changes:

  • Extend LanguageSchema to include chinese_traditional_{1k,5k,10k,50k}.
  • Add the new Traditional Chinese variants to the chinese language group for UI selection.
  • Add new language asset files for chinese_traditional_1k and chinese_traditional_5k.

Reviewed changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 3 comments.

File Description
packages/schemas/src/languages.ts Adds new Traditional Chinese language enum values so they’re recognized/validated across the app.
frontend/src/ts/constants/languages.ts Adds the new Traditional Chinese variants to the chinese group so they appear in UI groupings.
frontend/static/languages/chinese_traditional_1k.json New 1k Traditional Chinese word list asset.
frontend/static/languages/chinese_traditional_5k.json New 5k Traditional Chinese word list asset.

frontend/static/languages/chinese_traditional_1k.json Outdated
"除了",
"企業",
"終於",
"總統",
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate word in list: "總統" appears multiple times in this file; frontend/scripts/check-assets.ts flags even 1 duplicate. Remove duplicates / regenerate list with unique entries.

Suggested change
"總統",

Copilot uses AI. Check for mistakes.
frontend/static/languages/chinese_traditional_1k.json Outdated
"重大",
"之中",
"人才",
"總統",
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same duplicate as above: "總統" is repeated (already listed earlier). Dedupe list to satisfy assets validation.

Suggested change
"總統",
"領袖",

Copilot uses AI. Check for mistakes.
packages/schemas/src/languages.ts
Comment on lines +58 to +60
"chinese_traditional_1k",
"chinese_traditional_5k",
"chinese_traditional_10k",
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description mentions chinese_traditional_6k.json, but schema/group add chinese_traditional_5k instead. Either update description or rename/add the intended 6k list to match.

Copilot uses AI. Check for mistakes.
@github-actions github-actions bot removed the format Ask the bot to fix formatting on this pr label Feb 6, 2026
@fehmer
Copy link
Member

fehmer commented Feb 6, 2026

hi @nota-noob , thank you for your contribution. Could you add the bcp47 property to the existing https://github.com/monkeytypegame/monkeytype/blob/master/frontend/static/languages/chinese_traditional.json as well?

@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 6, 2026
@nota-noob
Fix duplicate character
3ea8d89 
Use the simplified to traditional pipeline for 1k as well (had only used for 5k, 10k, 50k)
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

assets Languages, themes, layouts, etc. frontend User interface or web stuff packages Changes in local packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nota-noob @fehmer @monkeytypegeorge